More verbose and accurate version displays #2382
Merged
+18
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HebaruSan
added
Bug
politas
added a commit
that referenced
this pull request
Mar 22, 2018
politas
removed
Bug
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problems
GUI's "Max KSP Version" column isn't always accurate; it assumes that the module version that CKAN considers "latest" always has the max KSP version, which sometimes is not the case. This was originally fixed in #2131, but the fix was reverted in #2150 as part of the rollback of #1929, as reported in KSP-CKAN/NetKAN#6368.
The Versions tab only shows the highest compatible game version, even though it's very common for mods to be compatible with a range of many game versions.
The prompt to choose a mod to satisfy a virtual dependency ("provides"-based) doesn't show the download host or file size, even though other places do.
Changes
Now #2131's change is back.
Now the Versions tab will show the full range of each module version's game versions:
Now when you are prompted to select a mod to satisfy a virtual dependency, the download host and file size will be shown to help inform your choice (already previously done for the change set confirmation list and the recommendation/suggestion list):